update to fix data race - #39
Open
IrisesD wants to merge 1 commit into
Open
Conversation
|
There is no concurrency here (this is a documented compiler ability). And if there was, the mutex wouldn't do anything, since the only concurrency is in the assignment itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, the
Shuffle()function in training/model.go is:which uses the
rand.Intnand performs write in a concurrent way. When theShuffle()function is called in a concurrent way, there will be race condition error:I suggest we should add a mutex lock to the function, as this PR does.